Skip to content

Conversation

@chunqilu
Copy link
Contributor

Issue

Recent https://github.com/aws/code-editor/actions/runs/21270251703 reports that there are two high risk vulnerability,

  • Undici, fixed version 7.18.2
  • node-tar, fixed version 7.5.4

we need to mitigate them.

Description of Changes

This change

  • updates undici to ^7.18.2 in package.json
  • updates node-tar to ^7.5.4 by backport a vscode security fix microsoft/vscode@1deca73 which replaces gulp-untar with custom untar implementation and update dependencies. The change is made in original gulp js build script instead of first converting to ts as in microsoft/vscode@fcfb37c to minimize changes.

Testing

manual test locally

Screenshots/Videos

Additional Notes

Backporting


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chunqilu chunqilu requested review from a team as code owners January 26, 2026 09:40
@chunqilu chunqilu merged commit 7c46e41 into main Jan 26, 2026
3 checks passed
@chunqilu chunqilu deleted the tar-undici-update branch January 26, 2026 09:49
chunqilu added a commit that referenced this pull request Jan 27, 2026
* replace gulp-untar with custom implementation and update undici

* add new patch to all series

* fix typo

* remove gulp-untar
chunqilu added a commit that referenced this pull request Jan 27, 2026
* update Electron to 40.0.0 (#112)

* update electron and tar

* remove tar update as it needs more efforts

---------

Co-authored-by: Ubuntu <ubuntu@ip-172-31-94-189.ec2.internal>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-47-93.ec2.internal>

* update undici and tar to mitigate high risk vulnerbaility (#113)

* replace gulp-untar with custom implementation and update undici

* add new patch to all series

* fix typo

* remove gulp-untar

* cherry pick aba3461

* cherry pick 7b92da7

* cherry-pick 4ed4254

* cherry pick e686f07

---------

Co-authored-by: Ubuntu <ubuntu@ip-172-31-94-189.ec2.internal>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-47-93.ec2.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants