Skip to content

Conversation

@jackchuma
Copy link
Contributor

@jackchuma jackchuma commented Jan 29, 2026

Previously, each template contained its own copy of contract addresses with commented mainnet/sepolia values. This led to:

  • Repeated address definitions across templates
  • Risk of copy/paste errors or stale addresses
  • Manual effort to update addresses across multiple files

This new approach provides a single source of truth for network addresses, reducing maintenance burden and configuration errors.

  • Add centralized address configuration files (config/mainnet.env and config/sepolia.env) containing all standard contract and multisig addresses
  • Integrate network configs into all setup templates via Makefile includes
  • Add NETWORK validation requiring explicit mainnet or sepolia selection
  • Remove duplicate hardcoded addresses from individual template .env files
  • Move LEDGER_ACCOUNT defaults to network-level .env files

@linear
Copy link

linear bot commented Jan 29, 2026

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 29, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 1/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

@Sertug17
Copy link

thank you. i wish you good work.

@cb-heimdall
Copy link
Collaborator

Review Error for leopoldjoy @ 2026-01-29 23:57:06 UTC
User failed mfa authentication, see go/mfa-help

@jackchuma jackchuma requested a review from leopoldjoy January 30, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants