Add DeckCtrlElement class and integrate with Memory management #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds support for DeckCtrl memory elements to the Crazyflie firmware library. DeckCtrl is a new memory type that provides information about deck controllers including vendor/product IDs, firmware version, board name/revision, and manufacturing date.
Changes:
- Added two new memory type constants (TYPE_DECKCTRL_DFU and TYPE_DECKCTRL) to MemoryElement
- Created a new DeckCtrlElement class that parses and validates 32-byte DeckCtrl info blocks with checksum verification
- Integrated DeckCtrlElement into the memory management system
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| cflib/crazyflie/mem/memory_element.py | Added TYPE_DECKCTRL_DFU (0x20) and TYPE_DECKCTRL (0x21) constants and their string representations |
| cflib/crazyflie/mem/deckctrl_element.py | New file implementing DeckCtrlElement class with parsing, validation, and callback handling for DeckCtrl memory |
| cflib/crazyflie/mem/init.py | Imported DeckCtrlElement and added handler for TYPE_DECKCTRL memory type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.