-
Notifications
You must be signed in to change notification settings - Fork 169
docs: Move composefs tracking from issue #1190 to docs #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The composefs backend implementation has largely landed. Consolidate tracking of known issues into the docs, categorized by severity: - Deployment blockers: GC, SELinux enforcing=0, OCI registry install - Important: Sealed image build UX, kargs.d support - Long-term: Unified storage, UKI/systemd-boot improvements This allows closing the original tracking issue bootc-dev#1190. Assisted-by: OpenCode (Claude Sonnet 4) Signed-off-by: Colin Walters <walters@verbum.org>
985899f to
9eebda0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the composefs documentation by moving the list of known issues from a GitHub tracking issue into the markdown file itself. The changes are well-structured, categorizing issues into deployment blockers, important items, and long-term goals, which significantly improves clarity. My review includes a couple of suggestions to further enhance the completeness and consistency of the documentation.
| - **SELinux**: Currently uses `enforcing=0` in the kernel command line (see [#1826](https://github.com/bootc-dev/bootc/issues/1826)) | ||
| - **kargs.d**: Custom kernel arguments from `/usr/lib/bootc/kargs.d` are not yet automatically included in sealed UKIs | ||
| - [Sealed image build UX](https://github.com/bootc-dev/bootc/issues/1498): Streamlined tooling for building sealed images | ||
| - **kargs.d**: Custom kernel arguments from `/usr/lib/bootc/kargs.d` not yet included in sealed UKIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of bold formatting for the kargs.d item is inconsistent with the other items in this list, which are either links or plain text. For better visual consistency, I suggest removing the bolding.
| - **kargs.d**: Custom kernel arguments from `/usr/lib/bootc/kargs.d` not yet included in sealed UKIs | |
| - kargs.d: Custom kernel arguments from `/usr/lib/bootc/kargs.d` not yet included in sealed UKIs |
| - [#1826](https://github.com/bootc-dev/bootc/issues/1826) - SELinux enforcement with composefs | ||
| - [#20](https://github.com/bootc-dev/bootc/issues/20) - Unified storage (long-term goal) | ||
| - [#806](https://github.com/bootc-dev/bootc/issues/806) - UKI/systemd-boot tracker | ||
| - [Unified storage](https://github.com/bootc-dev/bootc/issues/20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears the tracker for UKI/systemd-boot improvements (#806) was omitted from the new 'Known Issues' section. The PR description mentions this as a long-term goal, and it was present in the old 'Related Issues' list. It would be good to include it here for completeness.
| - [Unified storage](https://github.com/bootc-dev/bootc/issues/20) | |
| - [Unified storage](https://github.com/bootc-dev/bootc/issues/20) | |
| - [UKI/systemd-boot improvements](https://github.com/bootc-dev/bootc/issues/806) |
We need some work in e.g. bcvk among others to have this work. Closes: bootc-dev#1940 Signed-off-by: Colin Walters <walters@verbum.org>
The composefs backend implementation has largely landed. Consolidate tracking of known issues into the docs, categorized by severity:
Closes: #1190
Assisted-by: OpenCode (Opus 4.5)