-
Notifications
You must be signed in to change notification settings - Fork 3
renovate: Add git-refs custom manager for commit SHA tracking #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances our Renovate configuration by integrating a new custom manager. This addition enables the automated tracking and updating of Git commit SHAs within GitHub Actions workflow files, ensuring that pinned references remain current with the latest commits on specified branches. This improves the maintainability and security of our CI/CD pipelines by reducing manual updates and ensuring dependencies are up-to-date. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new custom regex manager to Renovate for tracking Git commit SHAs in GitHub Actions workflows. The implementation is a good start, but the regular expression could be made more robust to handle variations in formatting and to prevent potential parsing failures. I've left a specific suggestion to improve the regex.
d92ee9a to
5eaa40e
Compare
gursewak1997
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like wrong commit in here.
Add a custom regex manager to track git commit SHAs in Justfiles and YAML workflows. The pattern matches both double-quoted (Justfile) and single-quoted (YAML) strings containing 40-character commit SHAs. Example usage: # renovate: datasource=git-refs depName=https://github.com/org/repo branch=main export VAR := env("VAR", "<40-char-sha>") # Justfile VAR: '<40-char-sha>' # YAML This enables Renovate to automatically update pinned commit references when the tracked branch advances. Assisted-by: OpenCode (Claude Sonnet 4)
5eaa40e to
4617502
Compare
Add a custom regex manager to track git commit SHAs in GitHub Actions workflow files. The pattern matches:
This enables renovate to automatically update pinned commit references when the tracked branch (e.g., main) advances.
Assisted-by: Claude Sonnet 4 (via OpenCode)