-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Only create ConcurrentState in a Store when CM async is enabled
#12377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Only create ConcurrentState in a Store when CM async is enabled
#12377
Conversation
e580461 to
617ebec
Compare
Creating the default `ConcurrentState` will create a `FuturesUnordered` which will allocate. By making this state optional, we can keep making progress on bytecodealliance#12069, and put off dealing with `FuturesUnordered` until when we are ready to try and make CM async code handle OOMs.
617ebec to
3ce619b
Compare
|
So I got things working, but I had to effectively turn |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
DetailsTo modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
Creating the default
ConcurrentStatewill create aFuturesUnorderedwhich will allocate. By making this state optional, we can keep making progress on #12069, and put off dealing withFuturesUnordereduntil when we are ready to try and make CM async code handle OOMs.