GGUF loader fixes: tokenizer assignment, embed cast call, and path resolution #412
+220
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix tokenizer model_type assignment (was comparison) - fix cast_bias_weight call signature in embedding forward
- add resolve_full_path helper to centralize path lookup - add resolve_clip_path with smart fallback logic - fix mutable default argument in update_folder_names_and_paths - add FileNotFoundError with descriptive messages - apply pep8 formatting for consistency
Add _dropdown() and _ensure_dropdown() helper functions to provide consistent dropdown configuration format expected by ComfyUI frontend in newer builds. Update all GGUF loader classes (UnetLoaderGGUF, UnetLoaderGGUFAdvanced, CLIPLoaderGGUF, DualCLIPLoaderGGUF, TripleCLIPLoaderGGUF, QuadrupleCLIPLoaderGGUF) to use the new helpers, ensuring proper frontend dropdown formatting with default value support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
model_typeassignment and embeddingcast_bias_weightcall signature.Testing
Notes
Cherry-picked from the AirPods fork; resolved a small conflict to preserve upstream metadata handling in
UnetLoaderGGUF.