Fix signature Domain.__init__ and quadrants format #753
+21
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using PETSc, the example examples/euler_2d/quadrants.py throws an error since PetClaw's geometry.Domain.__init__ is not safeguarded against an instantiation like: domain = pyclaw.Domain([0.,0.],[1.,1.],[100,100]) This example also throws an error since 'ascii' was the default format even when using PETSc.
Member
|
Thanks!
We used to run all the regression tests in parallel as well. The main obstacle to doing that now is that we don't have PETSc and petsc4py set up in our CI. If you want to tackle that, you would be a hero. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two small issues:
examples/euler_2d/quadrants.pythrows an error since PetClaw's geometry.Domain.init is not safeguarded against an instantiation like:domain = pyclaw.Domain([0.,0.],[1.,1.],[100,100]), which is accepted in the serial version.'ascii'was the default format even when using PETSc.Maybe we could include a couple of PetClaw runs in the CI testing workflow to catch more of these.