devices: Refactor to make virtqueues fully created at transport layer #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtjhrc
force-pushed
the
refactor-virtqueues
branch
3 times, most recently
from
d2d1b62 to
162fdfb
Compare
…r (mmio) Refactor the MmioTransport to fully construct the virtqueues on behalf of the device. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Make the worker thread wait on the queue events directly instead of having an event_handler which would forward the event. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Instead of each device manually enabling the event_idx for each queue, let's make the transport layer configure the queues properly based on the acknowledged features. If it is necessary to disable this for some specific queue in the future (unlikely) we could an option for this in QueueConfig or the device could override this. Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
refactor-virtqueues
branch
from
162fdfb to
2d21135
Compare
mtjhrc
requested review from
MatiasVara,
jakecorrenti,
slp and
tylerfanelli
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.