-
Notifications
You must be signed in to change notification settings - Fork 149
docs(cb): add circuit breaker documentation #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jeanduplessis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haarchri would you please add these changes to the pages in the content/master/ directory as well please.
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
fd6f99e to
5b37df0
Compare
|
@jeanduplessis done |
jeanduplessis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM from a docs site perspective.
jbw976
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haarchri can you address (or suppress if justified) the Vale errors? https://github.com/crossplane/docs/actions/runs/21436999125/job/61730073135?pr=1048
jbw976
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @haarchri for taking the initiative to get the operational usage of the circuit breaker documented! I've left some comments for you to consider
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
jbw976
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, looks good to me now @haarchri, thank you very much! 🙇♂️

add circuit breaker documentation
Fixes: #1015