Skip to content

fix: prevent feedback loop caused by updating findings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgtoj merged 1 commit into from
Dec 2, 2025
Merged

fix: prevent feedback loop caused by updating findings #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,16 @@ func (a *App) Process(ctx context.Context, evt events.SecurityHubEventInput) err
a.Logger.Debug("finding matched rule", "rule", matchedRule.Name)
}

// skip if finding is already in the desired state to avoid feedback loops
if int32(finding.StatusID) == matchedRule.Action.StatusID {
if a.Config.DebugEnabled {
a.Logger.Debug("finding already in desired state, skipping update",
"uid", finding.Metadata.UID,
"status_id", finding.StatusID)
}
return nil
}

err := a.CloseFinding(ctx, finding, matchedRule.Action.StatusID, matchedRule.Action.Comment)
if err != nil {
return errors.Wrap(err, "failed to auto-close finding")
Expand Down