WIP #267 - Fail build if missing and add analysis code #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that the `ubuntu-slim` runner has a hardcoded limit of 15 mins per job.
Seems I had the syntax wrong.
I found out that GitHub actions uses the fast-fail behaviour. So that means that it's not advancing past the first line of script that fails. So, all my failure handling logic is ineffective and not being executed. This should fix that by disabling fast-fail on these two steps.
I had assumed an action named "setup chrome" might actually do everything required to setup chrome by default. Apparently not :-/
This might tell me why Chrome dies
Also add some docco, also exclude duplicate files from docs build.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #267 - Ensure that JS tests include coverage.