Skip to content

Conversation

@orionmiz
Copy link
Collaborator

@orionmiz orionmiz commented May 7, 2025

Summary by CodeRabbit

릴리스 노트

  • Refactor
    • Activity 컴포넌트 타입 시스템을 정리했습니다.
    • 컴포넌트 타입 선언을 더욱 명시적으로 개선했습니다.
    • 내부 구조를 정렬하여 코드 유지보수성을 향상시켰습니다.

✏️ Tip: You can customize this high-level summary in your review settings.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 7, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stackflow-docs d69633a Visit preview May 07 2025, 08:01 AM

@vercel
Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ❌ Failed (Inspect) May 7, 2025 7:59am

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: 5765b1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 7, 2025

Deploying stackflow-demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5765b1c
Status: ✅  Deploy successful!
Preview URL: https://b7a1dd4b.stackflow-demo.pages.dev
Branch Preview URL: https://future-activity-component-ty.stackflow-demo.pages.dev

View logs

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 7, 2025

commit: 5765b1c

@orionmiz orionmiz changed the title fix(react): exclude lazy component types from stable fix(react): exclude lazy component type from stable May 7, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stackflow-docs 5765b1c Commit Preview URL Jan 16 2026, 09:17 AM

@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Reorganized internal type exports for clearer, more consistent public surface
    • Activity component type now exposed from the stable export location; no runtime or behavioral changes

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Adds a new exported stable type ActivityComponentType, updates stable and future index exports to use or re-export types, and adjusts a single import in the loader plugin to reference the new local type; no runtime behavior changes.

Changes

Cohort / File(s) Summary
New stable type
integrations/react/src/stable/ActivityComponentType.tsx
Adds exported type alias ActivityComponentType<T extends { [K in keyof T]: any } = {}> = StaticActivityComponentType<T> (type-only addition).
Stable index export update
integrations/react/src/stable/index.ts
Removes previous alias export of an internal type and adds direct export of the new ./ActivityComponentType.
Loader import path change
integrations/react/src/future/loader/loaderPlugin.tsx
Changes import source of ActivityComponentType from ../../__internal__/ActivityComponentType to ../ActivityComponentType.
Future index re-export added
integrations/react/src/future/index.ts
Adds export * from "../__internal__/MonolithicActivityComponentType" to future exports (type re-export only).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a description explaining why the lazy component type is being excluded from stable and how the reorganization affects users of the stable API.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reorganizing ActivityComponentType imports/exports to exclude the lazy component type from the stable API.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 24d0238 and a3239c4.

📒 Files selected for processing (1)
  • integrations/react/src/future/index.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Write source in TypeScript with strict typing enabled across the codebase

Files:

  • integrations/react/src/future/index.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Workers Builds: stackflow-docs
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
integrations/react/src/future/index.ts (1)

3-3: LGTM! Re-export aligns with the PR objective.

The addition of MonolithicActivityComponentType to the future API surface is consistent with the goal of keeping the full type (including lazy components) available in future while stable now exposes only StaticActivityComponentType as ActivityComponentType. No duplicate symbol exports detected across modules.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This reverts commit 6117c96.
@orionmiz orionmiz closed this Jan 16, 2026
@orionmiz orionmiz reopened this Jan 16, 2026
@orionmiz orionmiz force-pushed the future-activity-component-type branch from c958937 to 9755c8a Compare January 16, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants