Hba records simplification #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 98.72% 98.71% -0.02%
==========================================
Files 10 10
Lines 1181 1171 -10
==========================================
- Hits 1166 1156 -10
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlax
suggested changes
Dec 6, 2024
pgiraud
force-pushed
the
hba_records_simplification
branch
from
3246453 to
350c898
Compare
dlax
suggested changes
Dec 6, 2024
pgiraud
force-pushed
the
hba_records_simplification
branch
2 times, most recently
from
fc5fbac to
998f2fa
Compare
pgiraud
force-pushed
the
hba_records_simplification
branch
from
998f2fa to
1ca02a7
Compare
We follow the names used by postgresql (https://www.postgresql.org/docs/current/auth-pg-hba-conf.html). `databases` and `users` are accessible via properties though.
The values argument wasn't really useful. It also makes Mypy happy with the following syntax: HBARecord(**a_mapping) The previous required syntax was: HBARecord(values=a_mapping)
pgiraud
force-pushed
the
hba_records_simplification
branch
from
1ca02a7 to
4dabab3
Compare
Member
Author
|
I resolved the remaining requested changes, and rebased the branch onto master. Please review again. |
dlax
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.