-
Notifications
You must be signed in to change notification settings - Fork 55
[PECOBLR-1143] Implement telemetry Phase 4-5: Export infrastructure and opt-in configuration #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samikshya-db
wants to merge
1
commit into
main
Choose a base branch
from
stack/PECOBLR-1143-telemetry-phase4-5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| package telemetry | ||
|
|
||
| import ( | ||
| "context" | ||
| "net/http" | ||
| "strconv" | ||
| "time" | ||
| ) | ||
|
|
@@ -92,3 +94,49 @@ | |
|
|
||
| return cfg | ||
| } | ||
|
|
||
| // isTelemetryEnabled checks if telemetry should be enabled for this connection. | ||
| // Implements the priority-based decision tree for telemetry enablement. | ||
| // | ||
| // Priority (highest to lowest): | ||
| // 1. forceEnableTelemetry=true - Bypasses all server checks (testing/internal) | ||
| // 2. enableTelemetry=false - Explicit opt-out (always disabled) | ||
| // 3. enableTelemetry=true + Server Feature Flag - User opt-in with server control | ||
| // 4. Server Feature Flag Only - Default behavior (Databricks-controlled) | ||
| // 5. Default - Disabled (false) | ||
| // | ||
| // Parameters: | ||
| // - ctx: Context for the request | ||
| // - cfg: Telemetry configuration | ||
| // - host: Databricks host to check feature flags against | ||
| // - httpClient: HTTP client for making feature flag requests | ||
| // | ||
| // Returns: | ||
| // - bool: true if telemetry should be enabled, false otherwise | ||
| func isTelemetryEnabled(ctx context.Context, cfg *Config, host string, httpClient *http.Client) bool { | ||
| // Priority 1: Force enable bypasses all server checks | ||
| if cfg.ForceEnableTelemetry { | ||
| return true | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if we take the config overlay approach that client side config take priority? we won't need the concept of force enablement? |
||
|
|
||
| // Priority 2: Explicit opt-out always disables | ||
| // When enableTelemetry is explicitly set to false, respect that | ||
| if !cfg.EnableTelemetry { | ||
| return false | ||
| } | ||
|
|
||
| // Priority 3 & 4: Check server-side feature flag | ||
| // This handles both: | ||
| // - User explicitly opted in (enableTelemetry=true) - respect server decision | ||
| // - Default behavior (no explicit setting) - server controls enablement | ||
| flagCache := getFeatureFlagCache() | ||
| serverEnabled, err := flagCache.isTelemetryEnabled(ctx, host, httpClient) | ||
| if err != nil { | ||
| // On error, respect default (disabled) | ||
| // This ensures telemetry failures don't impact driver operation | ||
| return false | ||
| } | ||
|
|
||
| return serverEnabled | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in C# we took the effort that extend the config to all config, not just client telemetry. we may want to do the same.