Virtualize and Modularize DataSetLoader logic #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- virtualize DataSetLoader - separate and modularize HDF5, MFD loaders and consolidate helper methods - organize dataset types into a package together - update callers, minor cleanups - use Optional instead of checked IOExceptions - add javadoc - organize dataset classes together - remove bench2d and loader
jshook
requested review from
MarkWolters,
marianotepper and
tlwillke
as code owners
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
MarkWolters
reviewed
Jan 16, 2026
| try { | ||
| DataSet ds = DataSetLoader.loadDataSet(datasetName); | ||
| DataSet ds = DataSets.loadDataSet(datasetName).orElseThrow( | ||
| () -> new IllegalStateException("Dataset " + datasetName + " not found") |
Contributor
There was a problem hiding this comment.
Why IllegalStateException here? I believe all the other checks just use RuntimeException
MarkWolters
reviewed
Jan 16, 2026
| private static final String infraBucketName = "jvector-datasets-infratest"; | ||
| private static final String fvecDir = "fvec"; | ||
| private static final String bucketName = "astra-vector"; | ||
| private static final List<String> bucketNames = List.of(bucketName, infraBucketName); |
Contributor
There was a problem hiding this comment.
We should probably just move everything to the infratest bucket to avoid having to use multiple buckets here, although that's not a comment on this PR. This is fine, just follows the existing logic.
MarkWolters
reviewed
Jan 16, 2026
...es/src/main/java/io/github/jbellis/jvector/example/benchmarks/datasets/DataSetLoaderMFD.java
Show resolved
Hide resolved
MarkWolters
approved these changes
Jan 16, 2026
Contributor
MarkWolters
left a comment
MarkWolters
left a comment
There was a problem hiding this comment.
Left a few comments but they are not necessarily things that need to be addressed in this PR, overall looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step-wise change to streamline dataset loading and usage. It does the following: