fix: Reduce agent max_polling_time to 10 minutes
#8550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMHO, if a test has to wait for one hour for a response to be produced, then it's not a very useful test. And regardless of that, one hour should not be the default for every single system test.
basvandijk
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO, if a test has to wait for one hour for a response to be produced, then it's not a very useful test. And regardless of that, one hour should not be the default for every single system test.
This is intended as a fix for the significant flakiness experienced recently by
//rs/tests/message_routing:state_sync_malicious_chunk_test. All the failures are timeouts. And the last relevant message before the test times out isChecking for subnet progress.... After which, the test proceeds to make a canister call that never completes and is never retried (because the test expires before the call, after 3600 seconds).The other half of the fix (dfinity/agent-rs#693, which will have to wait for an
ic-agentrelease) is to bail out if the status is stillUnknownafter 5 minutes, regardless of the configuredmax_polling_time.