fix: PocketIcBuilder::with_nns_state and PocketIcBuilder::with_subnet_state on Windows #8628
+5
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
changed the title
alin-at-dfinity
approved these changes
Jan 30, 2026
Any commits made after this event will not be merged.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2026
…_state on Windows (#8628) This PR makes the PocketIC library perform the conversion of the state directory path from its Windows-native form to the WSL-native form. This way, users of the PocketIC library (e.g., tests) do not have to perform the conversion repeatedly at all call sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the PocketIC library perform the conversion of the state directory path from its Windows-native form to the WSL-native form. This way, users of the PocketIC library (e.g., tests) do not have to perform the conversion repeatedly at all call sites.