Remove $(RepoRootDir) dependency from Debugger.Tests.Config.txt files #5684

Copilot · 2026-01-16T16:48:29Z

Original prompt

Our general goal is to run the diagnostics tests on Helix. This requires packaging up the built test binaries then running them on a remote machine.

Currently, the unit tests Debugger.Tests.Config.txt files rely on the $(RepoRootDir). Which is not consistent when moved to another machine. We've already reduced out dependency on this by copying files to the artifacts dir.

Can you update the Debugger.Tests.Config.txt files in CommonTestRunner, DbgShim.UnitTests, and SOS.UnitTests to no longer user $(RepoRootDir).

If we need access to the files referenced by $(RepoRootDir), we should copy them to the artifacts dir and have a path relative to the $(ArtifactsDir).

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

… RepoRootDir Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

max-charlamb · 2026-01-16T17:31:31Z

While we're making these changes, can we move the 'free-floating' debuggees under src/test/ to under the CommonTestRunner/Debuggees similar to the specific DbgShim and SOS debuggees.

max-charlamb · 2026-01-16T17:30:34Z

src/tests/CommonTestRunner/CommonTestRunner.csproj

+      DestinationFolder="$(DebuggeesDestDir)/Tracee/%(RecursiveDir)"
+      SkipUnchangedFiles="true" />
+    <Copy SourceFiles="@(EventPipeTraceeFiles)"
+      DestinationFolder="$(DebuggeesDestDir)/EventPipeTracee/%(RecursiveDir)"
+      SkipUnchangedFiles="true" />
+    <Copy SourceFiles="@(StackTraceeFiles)"
+      DestinationFolder="$(DebuggeesDestDir)/StackTracee/%(RecursiveDir)"
+      SkipUnchangedFiles="true" />


This is missing ExitCodeTracee.

Added ExitCodeTracee and moved all free-floating debuggees (Tracee, EventPipeTracee, StackTracee, ExitCodeTracee) to CommonTestRunner/Debuggees in 673c858.

max-charlamb · 2026-01-16T17:31:53Z

@copilot , address feedback

…itCodeTracee Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot · 2026-01-16T17:42:27Z

While we're making these changes, can we move the 'free-floating' debuggees under src/test/ to under the CommonTestRunner/Debuggees similar to the specific DbgShim and SOS debuggees.

Done. Moved Tracee, EventPipeTracee, StackTracee, and ExitCodeTracee to CommonTestRunner/Debuggees in 673c858.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

securitytools.pkgs.visualstudio.com
- Triggering command: /opt/hostedtoolcache/CodeQL/2.23.8/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.23.8/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…hub.com>

max-charlamb · 2026-01-16T18:24:54Z

@copilot , remove the nuget binary file from the diff. It looks like a mistake.

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot · 2026-01-16T18:33:32Z

@copilot , remove the nuget binary file from the diff. It looks like a mistake.

Removed the .nuget/nuget.exe binary file in 31f7957.

max-charlamb · 2026-01-20T20:55:36Z

@copilot , fix the build break. There are other references to RepoRootDir in the SOS.cs. Some tests (lldb specific) seem to expect this value and use it to find the path to the python scripts. Can you find the best way to resolve this.

…g lldbplugin.tests Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot · 2026-01-20T21:05:09Z

@copilot , fix the build break. There are other references to RepoRootDir in the SOS.cs. Some tests (lldb specific) seem to expect this value and use it to find the path to the python scripts. Can...

Fixed the RepoRootDir references in SOS.cs by:

Adding lldbplugin.tests directory (including Python scripts and TestDebuggee) to the copy target in SOS.UnitTests.csproj
Updating SOS.cs to use ArtifactsDir paths instead of RepoRootDir for both the Python scripts and TestDebuggee assembly

Commit: 8a5798d

Copilot

Pull request overview

This PR removes the dependency on $(RepoRootDir) from Debugger.Tests.Config.txt files to prepare the diagnostics tests for execution on Helix, where the repository structure may not be available. The changes enable tests to run on remote machines by copying necessary files to the artifacts directory and updating configuration files to use $(ArtifactsDir) paths instead.

Changes:

Updated Debugger.Tests.Config.txt files across CommonTestRunner, DbgShim.UnitTests, and SOS.UnitTests to use $(ArtifactsDir) instead of $(RepoRootDir) for debuggee sources and auxiliary MSBuild files
Added MSBuild targets to copy debuggee sources, AuxMsbuildFiles, and lldbplugin.tests to the artifacts directory during build
Moved debuggee projects (Tracee, EventPipeTracee, StackTracee, ExitCodeTracee) under CommonTestRunner/Debuggees subdirectory
Updated SOS.cs to use ArtifactsDir paths for lldbplugin tests
Removed RepoRootDir from generated Debugger.Tests.Common.txt configuration files

Reviewed changes

Copilot reviewed 13 out of 22 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/tests/CommonTestRunner/CommonTestRunner.csproj	Added CopyDebuggeeSources target to copy debuggee sources and aux files; removed RepoRootDir from config; excluded Debuggees folder from compilation
src/tests/CommonTestRunner/ConfigFiles/Windows/Debugger.Tests.Config.txt	Updated DebuggeeSourceRoot and DebuggeeMsbuildAuxRoot to use ArtifactsDir paths
src/tests/CommonTestRunner/ConfigFiles/Unix/Debugger.Tests.Config.txt	Updated DebuggeeSourceRoot and DebuggeeMsbuildAuxRoot to use ArtifactsDir paths
src/tests/DbgShim.UnitTests/DbgShim.UnitTests.csproj	Added CopyDebuggeeSources target; removed RepoRootDir from config files
src/tests/DbgShim.UnitTests/ConfigFiles/Windows/Debugger.Tests.Config.txt	Updated paths to use ArtifactsDir
src/tests/DbgShim.UnitTests/ConfigFiles/Unix/Debugger.Tests.Config.txt	Updated paths to use ArtifactsDir
src/tests/SOS.UnitTests/SOS.UnitTests.csproj	Added CopyDebuggeeSources target for debuggees, aux files, and lldbplugin tests; removed RepoRootDir
src/tests/SOS.UnitTests/SOS.cs	Updated to use ArtifactsDir for lldbplugin.tests and TestDebuggee paths
src/tests/SOS.UnitTests/ConfigFiles/Windows/Debugger.Tests.Config.txt	Updated paths to use ArtifactsDir
src/tests/SOS.UnitTests/ConfigFiles/Unix/Debugger.Tests.Config.txt	Updated paths to use ArtifactsDir
src/tests/Grape/Grape.csproj	Updated Tracee project reference to new location under CommonTestRunner/Debuggees
src/tests/CommonTestRunner/Debuggees/Tracee/*	New debuggee project with pipe-based synchronization
src/tests/CommonTestRunner/Debuggees/EventPipeTracee/*	New debuggee project for EventPipe testing with metrics and logging
src/tests/CommonTestRunner/Debuggees/StackTracee/*	New simple debuggee for stack testing
src/tests/CommonTestRunner/Debuggees/ExitCodeTracee/*	New debuggee that returns exit codes
src/tests/CommonTestRunner/Debuggees/Directory.Build.props	New build configuration file for debuggees

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

noahfalk

LGTM

@hoyosjs - any concerns?

Initial plan

45d895a

Copilot AI assigned Copilot and max-charlamb Jan 16, 2026

Copilot started work on behalf of max-charlamb January 16, 2026 16:49 View session

Update Debugger.Tests.Config.txt files to use ArtifactsDir instead of…

f4231a8

… RepoRootDir Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Update Debugger.Tests.Config.txt files to use relative paths~~ Remove $(RepoRootDir) dependency from Debugger.Tests.Config.txt files Jan 16, 2026

Copilot AI requested a review from max-charlamb January 16, 2026 17:10

Copilot finished work on behalf of max-charlamb January 16, 2026 17:10

max-charlamb reviewed Jan 16, 2026

View reviewed changes

Copilot started work on behalf of max-charlamb January 16, 2026 17:32 View session

Move free-floating debuggees to CommonTestRunner/Debuggees and add Ex…

673c858

…itCodeTracee Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.git…

d20624b

…hub.com>

Copilot AI requested a review from max-charlamb January 16, 2026 17:47

Copilot finished work on behalf of max-charlamb January 16, 2026 17:47

Copilot started work on behalf of max-charlamb January 16, 2026 18:26 View session

Remove accidentally included nuget.exe binary file

31f7957

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot finished work on behalf of max-charlamb January 16, 2026 18:34

Copilot started work on behalf of max-charlamb January 20, 2026 20:56 View session

Fix RepoRootDir references in SOS.cs by using ArtifactsDir and copyin…

8a5798d

…g lldbplugin.tests Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot finished work on behalf of max-charlamb January 20, 2026 21:06

max-charlamb marked this pull request as ready for review January 21, 2026 16:33

max-charlamb requested a review from a team as a code owner January 21, 2026 16:33

Copilot AI review requested due to automatic review settings January 21, 2026 16:33

Copilot started reviewing on behalf of max-charlamb January 21, 2026 16:33 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

noahfalk approved these changes Jan 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove $(RepoRootDir) dependency from Debugger.Tests.Config.txt files #5684

Remove $(RepoRootDir) dependency from Debugger.Tests.Config.txt files #5684

Copilot AI commented Jan 16, 2026 •

edited

Loading

Uh oh!

max-charlamb commented Jan 16, 2026

Uh oh!

max-charlamb Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

max-charlamb commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

max-charlamb commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

max-charlamb commented Jan 20, 2026

Uh oh!

Copilot AI commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

noahfalk left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove $(RepoRootDir) dependency from Debugger.Tests.Config.txt files #5684

Are you sure you want to change the base?

Remove $(RepoRootDir) dependency from Debugger.Tests.Config.txt files #5684

Conversation

Copilot AI commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

max-charlamb commented Jan 16, 2026

Uh oh!

max-charlamb Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

max-charlamb commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

max-charlamb commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

max-charlamb commented Jan 20, 2026

Uh oh!

Copilot AI commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

noahfalk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jan 16, 2026 •

edited

Loading

Copilot AI commented Jan 16, 2026 •

edited

Loading