Skip to content

Conversation

@henrikjacobsenfys
Copy link
Member

@henrikjacobsenfys henrikjacobsenfys commented Jan 21, 2026

Also identified an issue with units for diffusion models. For now, only default units will be allowed. When all diffusion models are implemented I will look into allowing different units in diffusion models. #79
Closes #78

#69 should be merged in first

@henrikjacobsenfys henrikjacobsenfys added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] low Low importance labels Jan 21, 2026
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 99.22680% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.22%. Comparing base (2ef5011) to head (acff6fc).

Files with missing lines Patch % Lines
src/easydynamics/sample_model/sample_model.py 97.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
+ Coverage    97.83%   98.22%   +0.38%     
===========================================
  Files           16       22       +6     
  Lines          786     1128     +342     
===========================================
+ Hits           769     1108     +339     
- Misses          17       20       +3     
Flag Coverage Δ
unittests 98.22% <99.22%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrikjacobsenfys henrikjacobsenfys changed the base branch from master to develop January 21, 2026 12:26
@henrikjacobsenfys henrikjacobsenfys marked this pull request as draft January 21, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] low Low importance [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hardcode diffusion_unit to m^2/s

2 participants