refactor: activate rule @typescript-eslint/no-floating-promises #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but turn off for some exceptions
by moving/adding dependencies
Member
Author
|
The test run fails with 
even though Ithe PR doesn't change any really settings in package.json nor tsconfig? |
…30-no-unpublished-import refactor: activate eslint n/no-unpublished-import
…30-typescript-eslint-prefer-nullish-coalescing refactor: activate eslint typescript-eslint/prefer-nullish-coalescing
Trying to streamline the information given in the README for "new" users (including people who have not used it in a long time).
…30-no-unused-private-class-members refactor: activate rule no-unused-private-class-members
Bumps and [js-yaml](https://github.com/nodeca/js-yaml). These dependencies needed to be updated together. Updates `js-yaml` from 4.1.0 to 4.1.1 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) Updates `js-yaml` from 3.14.1 to 3.14.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…abot/npm_and_yarn/multi-75e6bc5210 chore(deps): bump js-yaml
…iankb-modbus-readme-update1 WIP: Update Modbus README.md
Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.18 to 3.10.0. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Commits](patriksimek/vm2@3.9.18...v3.10.0) --- updated-dependencies: - dependency-name: vm2 dependency-version: 3.10.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…AExample Improved opcua example
…sc-readme-revision docs: revise README
* feat(binding-http/http-server): generate id based http paths fix eclipse-thingweb#1458 * chore: remove files from another branch
…abot/npm_and_yarn/vm2-3.10.0 chore(deps): bump vm2 from 3.9.18 to 3.10.0
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…abot/npm_and_yarn/lodash-4.17.23 chore(deps): bump lodash from 4.17.21 to 4.17.23
…ttps://github.com/danielpeintner/thingweb.node-wot into danielpeintner-issue-1430-typescript-eslint-no-floating-promises
Member
|
@danielpeintner, you were adding catch statements even if you didn't update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1430