Fix usage of unsigned integers #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that more lines of code are executed during tests, which increases the code coverage.
Some of the UAttributes properties are defined as unsigned integers in the protocol specification. However, Java does not have native support for unsigned types, which can lead to issues when dealing with values that exceed the maximum value of a signed integer. Java 8 has introduced support for handling unsigned integers through methods in the Integer and Long classes. This commit updates the codebase to utilize these methods where appropriate, ensuring that unsigned integer values are handled correctly.
|
Code coverage report is ready! 📈
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the UAttributes properties are defined as unsigned integers in
the protocol specification. However, Java does not have native support for
unsigned types, which can lead to issues when dealing with values that exceed
the maximum value of a signed integer.
Java 8 has introduced support for handling unsigned integers through methods
in the Integer and Long classes. This commit updates the codebase to utilize
these methods where appropriate, ensuring that unsigned integer values are
handled correctly.