Skip to content

Conversation

@dphuang2
Copy link
Collaborator

@dphuang2 dphuang2 commented Jan 16, 2026

  • Introduced --env-file argument in the CLI for specifying the path to the .env file containing secrets.
  • Refactored the upload process to include a new function upload_secrets_to_fireworks that handles the uploading of secrets.
  • Updated the upload_command to optionally skip secret uploads if already handled.
  • Enhanced the evaluator upload process to ensure secrets are uploaded before ensuring evaluator existence.

Note

Improves secrets management and evaluator creation flow.

  • Adds --env-file to create rft for specifying a secrets file; secrets are now uploaded before evaluator checks/uploads
  • Introduces upload_secrets_to_fireworks and integrates it into both upload (optional via skip_secrets) and create rft paths
  • Detects existing Fireworks secrets via get_fireworks_secret, deselects them by default in prompts, and adds double-confirmation before overwriting
  • Enhances selection UX: marks existing secrets as [exists], defaults to only new secrets in non-questionary fallback, and improves masked logging
  • Updates _upload_and_ensure_evaluator to accept env_file/non_interactive and to call upload_command(..., skip_secrets=True)

Written by Cursor Bugbot for commit 39189e8. This will update automatically on new commits. Configure here.

- Introduced `--env-file` argument in the CLI for specifying the path to the .env file containing secrets.
- Refactored the upload process to include a new function `upload_secrets_to_fireworks` that handles the uploading of secrets.
- Updated the `upload_command` to optionally skip secret uploads if already handled.
- Enhanced the evaluator upload process to ensure secrets are uploaded before ensuring evaluator existence.
…ed first

- Moved the call to `upload_secrets_to_fireworks` to occur before checking the evaluator status, ensuring that secrets are available for evaluation.
- Removed redundant upload of secrets that was previously placed after the evaluator existence check.
- Implemented functions to check for existing secrets on Fireworks and confirm overwriting them with user prompts.
- Updated the secret selection process to deselect existing secrets by default, enhancing user experience and preventing accidental overwrites.
- Refactored the `upload_secrets_to_fireworks` function to incorporate these changes, ensuring a safer and more intuitive secret management workflow.
@dphuang2 dphuang2 merged commit b011c79 into main Jan 16, 2026
17 checks passed
@dphuang2 dphuang2 deleted the dhuang/dxe-552-prevent-overwriting-existing-fireworks_api_key branch January 16, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants