Skip to content

Fix bug in preprocess_fn codepath #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RNHTTR wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix bug in preprocess_fn codepath #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions eval_protocol/pytest/evaluation_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,12 +351,7 @@ def _log_eval_error(status: Status, rows: list[EvaluationRow] | None, passed: bo
apply preprocess_fn.
"""
if preprocess_fn:
if not data_loaders:
data = preprocess_fn(data)
else:
raise ValueError(
"preprocess_fn should not be used with data_loaders. Pass preprocess_fn to data_loaders instead."
)
data = preprocess_fn(data)

for row in data:
# generate a stable row_id for each row
Expand Down