-
Notifications
You must be signed in to change notification settings - Fork 245
feat: implement sync mode #2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tac0turtle
wants to merge
12
commits into
main
Choose a base branch
from
marko/sync_subscribe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e3a0ed3
feat: implement sync mode metrics and subscription functionality for …
tac0turtle a09461e
feat: add ProcessBlobs method to DARetriever interface and implement …
tac0turtle 2e9feab
Merge branch 'main' into marko/sync_subscribe
tac0turtle 9aa785f
make deps
tac0turtle 7bd2c8e
fix mocks
tac0turtle ecfcf83
syncing: fallback to catchup on subscribe failure
tac0turtle 3893ef3
Merge branch 'main' into marko/sync_subscribe
tac0turtle d5dabcc
Merge branch 'main' into marko/sync_subscribe
tac0turtle 127440b
fix after merge
tac0turtle 7d39e71
align subscribe with forced inclusion
tac0turtle a1f1a90
simplficiation
tac0turtle e953e20
simplify
tac0turtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package common | ||
|
|
||
| import blobrpc "github.com/evstack/ev-node/pkg/da/jsonrpc" | ||
|
|
||
| // BlobsFromSubscription returns non-empty blob data from a subscription response. | ||
| func BlobsFromSubscription(resp *blobrpc.SubscriptionResponse) [][]byte { | ||
| if resp == nil || len(resp.Blobs) == 0 { | ||
| return nil | ||
| } | ||
|
|
||
| blobs := make([][]byte, 0, len(resp.Blobs)) | ||
| for _, blob := range resp.Blobs { | ||
| if blob == nil { | ||
| continue | ||
| } | ||
| data := blob.Data() | ||
| if len(data) == 0 { | ||
| continue | ||
| } | ||
| blobs = append(blobs, data) | ||
| } | ||
|
|
||
| return blobs | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me while reading, appears a little confusing localHead in this context.
Is it querying the local node? is the last header that the DA has of my chain? is the last header that the DA layer has synced?
maybe this thought changes once all the review is done