Rename isInt64 to is_int64 and validate to_number input
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename bit64.isInt64 to bit64.is_int64 for Lua naming conventions (old name kept as alias for backwards compatibility) - bit64.to_number now validates input and accepts only numbers or proper Int64 values created with bit64.new() - bit64.from_number now accepts Int64 values as pass-through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bit64.isInt64tobit64.is_int64for Lua naming convention consistency. The old name is retained as an alias for backward compatibility.bit64.to_numberby adding input validation to accept only numeric values or validInt64objects created withbit64.new().bit64.from_numberto allowInt64values as direct pass-through.