Skip to content

Conversation

@russellwheatley
Copy link
Member

fixes #2300

When using the same phone number to verify (i.e. call verifyPhoneNumber()), if you use it before the timeout set on the phone provider has elapsed, the verifyPhoneNumber() call will hang and result in the loading screen never resolving.

This PR:

  • creates an exception that throws when the above occurs.
  • Checks the timeout and the time that has elapsed, if the call is made before the timeout, it throws the cool down exception.

The below is a recording of using the same phone number to verify within the timeout set (60 seconds), each time I try to move to verification code screen, it throws modal pop up with time left before cool down period is over, once the 60 seconds have elapsed, we are able to go to the verification code screen with the same number without verifyPhoneNumber() hanging.

Screen_recording_20260114_143153.webm

Copy link
Member

@demolaf demolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley merged commit 86c657e into version-10.0.0-beta02 Jan 19, 2026
5 checks passed
@russellwheatley russellwheatley deleted the 2300-auth-phone-hang branch January 19, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants