-
Notifications
You must be signed in to change notification settings - Fork 54
Refactor GemApiClient endpoints to use walletId #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated API endpoints in GemApiClient and related repository calls to use walletId as a path parameter instead of walletIndex as a query parameter. Adjusted affected repository methods and service calls to align with the new API structure. Added isDeviceRegistered endpoint and refactored device registration logic for improved clarity and correctness.
Summary of ChangesHello @gemcoder21, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively refactors several API client endpoints to use walletId as a path parameter instead of walletIndex as a query parameter. The changes are applied consistently across the repositories and services. The device registration logic in DeviceRepository has been improved for clarity and correctness by introducing an isDeviceRegistered check. I've added one comment regarding error handling that could be improved.
...ositories/src/main/kotlin/com/gemwallet/android/data/repositoreis/device/DeviceRepository.kt
Show resolved
Hide resolved
Added local tracking for device registration status to avoid unnecessary API calls. Enhanced error handling for device lookup, including re-registration if the device is not found remotely. Introduced new preferences key for device registration state.
Updated referral and rewards coordinator interfaces and implementations to require deviceId and walletId parameters. Modified GemApiClient endpoints to use device and wallet IDs in paths, and adjusted related data classes and repository logic accordingly. This change improves API consistency and aligns with backend requirements for device- and wallet-scoped operations.
Updated API endpoints in GemApiClient and related repository calls to use walletId as a path parameter instead of walletIndex as a query parameter. Adjusted affected repository methods and service calls to align with the new API structure. Added isDeviceRegistered endpoint and refactored device registration logic for improved clarity and correctness.