Skip to content

Conversation

@gemcoder21
Copy link
Collaborator

Updated API endpoints in GemApiClient and related repository calls to use walletId as a path parameter instead of walletIndex as a query parameter. Adjusted affected repository methods and service calls to align with the new API structure. Added isDeviceRegistered endpoint and refactored device registration logic for improved clarity and correctness.

Updated API endpoints in GemApiClient and related repository calls to use walletId as a path parameter instead of walletIndex as a query parameter. Adjusted affected repository methods and service calls to align with the new API structure. Added isDeviceRegistered endpoint and refactored device registration logic for improved clarity and correctness.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gemcoder21, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring of the GemApiClient to align with an updated API design, primarily by transitioning from walletIndex query parameters to walletId path parameters for wallet-specific operations. It also introduces a dedicated endpoint for checking device registration status and updates the device registration flow to leverage this new capability, enhancing clarity and correctness in device management and API interactions.

Highlights

  • API Endpoint Refactoring: Several API endpoints in GemApiClient and their corresponding calls in repository methods have been updated to use walletId as a path parameter instead of walletIndex as a query parameter. This change affects getTransactions, getAssets, and getNFTs.
  • New isDeviceRegistered Endpoint: A new API endpoint, /v1/devices/{device_id}/is_registered, has been added to GemApiClient to explicitly check if a device is already registered.
  • Refactored Device Registration Logic: The callRegisterDevice method in DeviceRepository has been refactored to utilize the new isDeviceRegistered endpoint, streamlining the device registration process by first checking registration status before attempting to register or update a device.
  • API Path Standardization: Several API paths related to subscriptions and price alerts have been standardized to follow a consistent /v1/devices/{device_id}/... structure, improving API consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively refactors several API client endpoints to use walletId as a path parameter instead of walletIndex as a query parameter. The changes are applied consistently across the repositories and services. The device registration logic in DeviceRepository has been improved for clarity and correctness by introducing an isDeviceRegistered check. I've added one comment regarding error handling that could be improved.

gemcoder21 and others added 3 commits January 29, 2026 21:18
Added local tracking for device registration status to avoid unnecessary API calls. Enhanced error handling for device lookup, including re-registration if the device is not found remotely. Introduced new preferences key for device registration state.
Updated referral and rewards coordinator interfaces and implementations to require deviceId and walletId parameters. Modified GemApiClient endpoints to use device and wallet IDs in paths, and adjusted related data classes and repository logic accordingly. This change improves API consistency and aligns with backend requirements for device- and wallet-scoped operations.
@furenster furenster marked this pull request as ready for review January 30, 2026 04:55
@furenster furenster merged commit 38cfd55 into main Jan 30, 2026
1 check failed
@furenster furenster deleted the device-route branch January 30, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants