-
-
Notifications
You must be signed in to change notification settings - Fork 229
chore: Allow Android bindings to be built using local maven artefacts #4873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4873 +/- ##
==========================================
- Coverage 73.86% 73.85% -0.01%
==========================================
Files 483 483
Lines 17577 17577
Branches 3464 3464
==========================================
- Hits 12983 12982 -1
Misses 3741 3741
- Partials 853 854 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Flash0ver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it to work on my machine.
Shall we add a brief instruction to CONTRIBUTING.md,
similar to https://github.com/getsentry/sentry-dotnet/pull/4551/changes#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055?
Done ✅ |
This is just for contributors... when we need to debug issues in the Sentry SDK for Java/Android, it's useful to be able to build the .NET SDK using locally built versions of the Maven artefacts, to be able to quickly add logs and iterate etc.
This PR adds a
UseLocalSentryMavenRepobuild property that does just that.#skip-changelog