Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 20, 2026

This PR is needed to address the following failure in the Kokoro Deps at HEAD Tests presubmit in PR #15468

________________ ERROR collecting tests/unit/test_writer_v1.py _________________
ImportError while importing test module '/tmpfs/src/github/google-cloud-python/packages/google-cloud-bigquery-storage/tests/unit/test_writer_v1.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.14/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tests/unit/test_writer_v1.py:25: in 
    from google.cloud.bigquery_storage_v1 import exceptions as bqstorage_exceptions
google/cloud/bigquery_storage_v1/__init__.py:31: in 
    from google.cloud.bigquery_storage_v1 import client, types
google/cloud/bigquery_storage_v1/client.py:24: in 
    from google.api_core import gapic_v1
.nox/core_deps_from_source-protobuf_implementation-upb/lib/python3.14/site-packages/google/api_core/gapic_v1/__init__.py:18: in 
    from google.api_core.gapic_v1 import method
.nox/core_deps_from_source-protobuf_implementation-upb/lib/python3.14/site-packages/google/api_core/gapic_v1/method.py:24: in 
    from google.api_core import grpc_helpers
.nox/core_deps_from_source-protobuf_implementation-upb/lib/python3.14/site-packages/google/api_core/grpc_helpers.py:23: in 
    import google.auth.transport.grpc
.nox/core_deps_from_source-protobuf_implementation-upb/lib/python3.14/site-packages/google/auth/transport/grpc.py:23: in 
    from google.oauth2 import service_account
.nox/core_deps_from_source-protobuf_implementation-upb/lib/python3.14/site-packages/google/oauth2/service_account.py:78: in 
    from google.auth import _service_account_info
.nox/core_deps_from_source-protobuf_implementation-upb/lib/python3.14/site-packages/google/auth/_service_account_info.py:20: in 
    from google.auth import crypt
.nox/core_deps_from_source-protobuf_implementation-upb/lib/python3.14/site-packages/google/auth/crypt/__init__.py:41: in 
    from google.auth.crypt import es
.nox/core_deps_from_source-protobuf_implementation-upb/lib/python3.14/site-packages/google/auth/crypt/es.py:21: in 
    import cryptography.exceptions
E   ModuleNotFoundError: No module named 'cryptography'

See googleapis/gapic-generator-python#2527 for more details

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical ModuleNotFoundError for the cryptography module that was causing failures in the Kokoro Deps at HEAD Tests presubmit. By upgrading the gapic-generator dependency to version 1.30.4, which includes cryptography in its constraints, the PR ensures the stability of the build process and prevents future test failures related to this missing dependency.

Highlights

  • Dependency Update: Upgraded the gapic-generator dependency from version 1.30.3 to 1.30.4.
  • Critical Bug Fix: This update resolves a ModuleNotFoundError for the cryptography module, which was causing failures in the Kokoro Deps at HEAD Tests presubmit.
  • Dependency Resolution: The new gapic-generator version 1.30.4 explicitly adds cryptography to its constraints, ensuring its availability and preventing future build issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gapic-generator dependency from version 1.30.3 to 1.30.4. The change is intended to resolve a ModuleNotFoundError for the cryptography package that was causing failures in the CI/CD pipeline. The update is straightforward and correctly addresses the issue described. The change looks good.

@parthea parthea marked this pull request as ready for review January 20, 2026 18:34
@parthea parthea requested review from a team as code owners January 20, 2026 18:34
@parthea parthea merged commit ae01133 into main Jan 20, 2026
26 checks passed
@parthea parthea deleted the parthea-patch-9 branch January 20, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants