chore(jdbc): shade bq sdk in jdbc 'all' package

[logachev]

Remove exclusion com.google.cloud.bigquery.* from shaded jar. Hit an issue with local tests that also bring BQ SDK dependency. Given that some deps of SDK are shaded, it creates an incompatibility.

Moving forward, shaded jar is meant to be used when generic JDBC driver is expected. Non-shaded thin jar can be used for specific integrations that can retrieve BQ-specific data rather than use it as a generic JDBC driver.

[gemini-code-assist]

Summary of Changes

Hello @logachev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the build configuration for the BigQuery JDBC driver to fully shade the BigQuery SDK within its 'all' package. This resolves dependency conflicts that previously occurred during local testing when the SDK was also present, ensuring a more robust and compatible driver. The change also implicitly clarifies the intended use cases for the shaded versus non-shaded driver distributions.

Highlights

• Shading Configuration Update: The exclusion for com.google.cloud.bigquery.* has been removed from the maven-shade-plugin configuration in google-cloud-bigquery-jdbc/pom.xml.
• BigQuery SDK Shading: This change ensures that the entire BigQuery SDK is now fully shaded within the JDBC driver's 'all' package.
• Dependency Conflict Resolution: The modification addresses an incompatibility issue encountered during local testing, where partial shading of the BQ SDK led to conflicts when the SDK was also present in the test environment.

Changelog

• google-cloud-bigquery-jdbc/pom.xml
  • Removed the <exclude>com.google.cloud.bigquery.*</exclude> entry from the maven-shade-plugin configuration, ensuring the BigQuery SDK is now fully shaded within the 'all' package.

Activity

• The pull request was authored by logachev.
• The author identified an incompatibility issue with local tests stemming from the BigQuery SDK's partial shading within the JDBC driver.
• The change aims to resolve this by fully shading the SDK, and clarifies that the shaded jar is for generic JDBC use, while the non-shaded thin jar is for specific integrations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the shading configuration in google-cloud-bigquery-jdbc/pom.xml to include and relocate the BigQuery SDK (com.google.cloud.bigquery.*) within the shaded 'all' JAR. This change correctly addresses potential dependency conflicts by isolating the driver's version of the BigQuery SDK. The approach is sound and the implementation is correct, improving the robustness of the shaded JDBC driver for generic use cases.