feat: Add support for opening via write_handle and fix write_handle type

[chandra-siri]

feat: Add support for opening via write_handle and fix write_handle type

[gemini-code-assist]

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the type accuracy within the asynchronous object streaming components of the storage client and overhauling the associated system tests. The type hint adjustments provide clearer API contracts and improved static analysis. Concurrently, the test suite has been updated to leverage pytest's fixture system for managing asyncio event loops and gRPC client instances, resolving potential concurrency issues and making the tests more robust and maintainable.

Highlights

• Type Hint Rectification: Updated type hints for 'handle', 'read_handle', and 'write_handle' parameters across several asynchronous object stream classes. This change refines the type definitions from generic 'bytes' to more specific types like '_storage_v2.BidiReadHandle', '_storage_v2.BidiWriteHandle', or 'Any' in the abstract base class, improving type safety and code clarity.
• Asynchronous Test Refactoring: The system tests for asynchronous operations have been significantly refactored. This includes introducing session-scoped pytest fixtures for managing asyncio event loops and gRPC client instances, which helps prevent deadlocks and streamlines the execution of asynchronous tests.
• New Test Case for Read Handles: A new test case, 'test_mrd_open_with_read_handle_over_cloud_path', was added to specifically validate the behavior of read handles when operating over cloud paths, ensuring comprehensive test coverage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly rectifies the type hints for various handle parameters, changing them from bytes to more specific types like _storage_v2.BidiReadHandle and _storage_v2.BidiWriteHandle. This significantly improves type safety and code clarity. Additionally, the system tests in tests/system/test_zonal.py have been substantially refactored to manage the asyncio event loop at a session level, which is a great improvement for test stability and performance. I have one minor suggestion to improve docstring consistency.

[chandra-siri]

/gcbrun(9bc6375)

The base branch was changed.