This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Change puts to use logger gem, improved detection of PID on windows #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks great! Unfortunately, both @ccammilleri and myself will be out of town the next couple of weeks, but i look forward to testing/merging this when we get back. |
|
Please, can you accept this pull request? |
Member
|
sure, I'll test it soon and get it merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it looks like logger is going to be used going forward, I went through and changed all the puts to use $log.info,$log.debug,$log.error type logic. The logging level can be set on line 5, however this should probably be moved to either the config file, or passes as a parameter to agent.rb.
Also discovered that on widows detection of the Hashcat PID was not reliable because of the 'ps aux' command. Moved to a native windows library improving the detection code and ensuring that when a task is killed on windows, that the agent will stop running the task.