Skip to content

[Snyk] Fix for 6 vulnerabilities #10756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/puppetdb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +38 to +42
Copy link

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes appear to be incorrect for a monorepo setup using Yarn workspaces and are likely to break the build.

  1. Incorrect Dependency Resolution: Replacing workspace:^ with specific versions (0.1.0, 0.0.1, 0.1.1) breaks the link to the local packages within the monorepo. This forces Yarn to fetch these packages from the public registry instead of using the local source code, which is not the intended behavior in a workspace setup.

  2. Major Dependency Downgrade: The versions being pinned are significant downgrades. For example, @backstage/core-components is being pinned to 0.1.0, but its version within this monorepo is 0.13.4-next.0. Similarly, @backstage/theme is pinned to 0.1.1 while its monorepo version is 0.4.1. Downgrading core packages so drastically is highly likely to cause build failures or runtime errors.

This seems to be an error by the Snyk automation, which may not fully support the workspace: protocol in Yarn. The correct approach would be to address the vulnerabilities within the workspace packages themselves.

Given these critical issues, and the fact that yarn.lock was not updated, I recommend reverting these changes.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "^4.0.0-alpha.57",
Expand Down
Loading