Skip to content

[Snyk] Fix for 6 vulnerabilities #10757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/dynatrace/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +31 to +33
Copy link

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change by Snyk is incorrect and will likely break the application.

Here's why:

  • Incorrect Version Pinning: This change replaces workspace:^ with very old, pinned versions of @backstage/core-components and @backstage/theme. In a Backstage monorepo, workspace:^ ensures that packages use the most recent versions of other packages from within the same monorepo. Pinning to old, published versions breaks this crucial mechanism.
  • Major Version Downgrade: The version of @backstage/core-components is being downgraded from 0.13.4-next.0 (in the workspace) to 0.1.0. Similarly, @backstage/theme is being downgraded from 0.4.1 to 0.1.1. Such a massive downgrade will almost certainly introduce breaking changes and cause build or runtime errors due to API incompatibilities.
  • Monorepo Integrity: This change undermines the integrity of the monorepo. All plugins should be using compatible versions of core libraries to ensure consistency and prevent runtime issues (e.g., with React contexts).

The PR description also warns that yarn.lock failed to update, which is another strong indicator that this change is problematic.

The correct approach to fix these vulnerabilities would be to either:

  1. Update the vulnerable transitive dependencies within the @backstage/core-components and @backstage/theme packages themselves.
  2. Use Yarn's resolutions field in the root package.json to force newer, non-vulnerable versions of the transitive dependencies across the entire project.

This PR should be closed and the vulnerabilities addressed manually. I'm suggesting reverting this change.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading