Skip to content

[Snyk] Fix for 6 vulnerabilities #10759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions plugins/catalog-backend-module-bitbucket-cloud/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-bitbucket-cloud-common": "0.1.0",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.13.0",
Comment on lines +49 to +57
Copy link

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change from Snyk has several critical issues that need careful review before merging:

  1. Dependency Downgrades: Some dependencies are being downgraded to much older versions. For example:

    • @backstage/integration is downgraded from workspace:^ (which resolves to 1.5.1 in the workspace) to 0.1.0.
    • @backstage/plugin-bitbucket-cloud-common is downgraded from workspace:^ (resolving to 0.2.8) to 0.1.0.
      These are major version downgrades and are very likely to cause breaking changes, reintroduce old bugs, and remove features that the plugin might depend on.

  2. Decoupling from Workspace: Changing dependencies from workspace:^ to pinned versions decouples this package from the rest of the monorepo. While this can be a temporary fix for vulnerabilities, it can lead to version conflicts and inconsistencies down the line. It's generally better to update the versions across the workspace if possible.

  3. Major Version Upgrades: Other dependencies are receiving major version upgrades (e.g., @backstage/backend-plugin-api from 0.5.x to 1.6.1). These also carry a high risk of breaking changes.

  4. Incomplete PR: The PR description explicitly warns: Failed to update the yarn.lock, please update manually before merging. Without an updated lock file, these dependency changes may not be correctly applied, and the build will be in an inconsistent state.

It seems the automated dependency resolution has found a valid, but incorrect, set of versions. It is highly recommended to reject this change and manually update the dependencies to appropriate versions that resolve the vulnerabilities without introducing breaking changes or downgrades. A better approach might be to update the root-level dependencies for the entire workspace.

"@backstage/plugin-events-node": "workspace:^",
"uuid": "^8.0.0",
"winston": "^3.2.1"
Expand Down
Loading