-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/plugin-permission-common from 0.0.0-use.local to 0.1.0 #10760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by upgrading the @backstage/plugin-permission-common package. However, the proposed change is incorrect and potentially harmful. It replaces a yarn workspace dependency (workspace:^) with a pinned, much older version (0.1.0), effectively downgrading it from the current workspace version of 0.7.7. This change breaks the monorepo's integrity and is likely to cause build failures or regressions. Additionally, the PR notes that it failed to update the yarn.lock file. Due to these critical issues, this PR should not be merged as is. The underlying vulnerabilities should be addressed by updating the dependencies within the @backstage/plugin-permission-common package itself or by other means that respect the monorepo structure.
| }, | ||
| "dependencies": { | ||
| "@backstage/plugin-permission-common": "workspace:^" | ||
| "@backstage/plugin-permission-common": "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change from workspace:^ to a pinned version 0.1.0 is incorrect and will likely cause issues. The workspace:^ protocol ensures that this package uses the local version of @backstage/plugin-permission-common from this monorepo, which is currently at version 0.7.7. Changing this to 0.1.0 is a significant downgrade and will cause this package to use an old, published version from the registry instead of the local one. This breaks the monorepo development workflow and could introduce bugs or break compatibility. This change should be reverted to keep the workspace dependency.
| "@backstage/plugin-permission-common": "0.1.0" | |
| "@backstage/plugin-permission-common": "workspace:^" |
WalkthroughThis pull request updates the dependency management for the example-todo-list-common plugin by transitioning from a workspace protocol reference to a fixed version for the @backstage/plugin-permission-common package. The change replaces the flexible workspace:^ reference with a pinned version 0.1.0, indicating a shift from local monorepo development to using published package versions. This type of change is typically made when preparing a package for publication or when moving away from a workspace-based development setup to ensure consistent dependency resolution across different environments. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant WS as Workspace
participant NPM as NPM Registry
participant Plugin as example-todo-list-common
Note over Dev,Plugin: Dependency Resolution Change
rect rgb(240, 240, 240)
Note over Dev,NPM: BEFORE: workspace:^ reference
Dev->>PM: Install dependencies
PM->>WS: Resolve @backstage/plugin-permission-common
WS-->>PM: Return local workspace package
PM->>Plugin: Link workspace dependency
end
rect rgb(220, 250, 220)
Note over Dev,NPM: AFTER: 0.1.0 specific version
Dev->>PM: Install dependencies
PM->>NPM: Fetch @backstage/plugin-permission-common@0.1.0
NPM-->>PM: Return published package v0.1.0
PM->>Plugin: Install versioned dependency
end
Note over Plugin: Plugin now uses published<br/>package instead of<br/>workspace reference
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/example-todo-list-common/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR pins the @backstage/plugin-permission-common dependency to a specific version in the example-todo-list-common plugin.
workspace:^to0.1.0in package.json