-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, initiated by Snyk, focuses on improving the project's security posture by resolving several identified vulnerabilities in its yarn dependencies. The core change involves updating specific Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix several vulnerabilities by updating dependencies. However, the proposed changes in plugins/home-react/package.json are incorrect. It pins @backstage/core-components and @backstage/core-plugin-api to version 0.1.0, which is a major downgrade from the versions used in the workspace. This will likely lead to build failures and runtime errors. The changes should be reverted, and the vulnerabilities should be addressed by updating the workspace packages themselves if necessary.
| "@backstage/core-components": "0.1.0", | ||
| "@backstage/core-plugin-api": "0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependency versions are being pinned to 0.1.0, which is a significant downgrade from the versions available in the workspace (@backstage/core-components is at 0.13.4-next.0 and @backstage/core-plugin-api is at 1.5.3). This will almost certainly cause breaking changes and build failures, as the rest of the code in this package expects much newer APIs.
While this change was likely automated by Snyk to fix vulnerabilities, the chosen versions are incorrect. Instead of pinning to these old versions, the workspace:^ protocol should be kept. If there are vulnerabilities, the packages in the workspace themselves should be updated. Please revert this change.
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^"
WalkthroughThis PR updates the dependency management strategy for the home-react plugin by replacing workspace protocol references with explicit version pinning. The change affects two core Backstage dependencies, transitioning from Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PKG as package.json
participant NPM as Package Manager
participant WS as Workspace Packages
participant REG as NPM Registry
Note over Dev,REG: Dependency Resolution Change
Dev->>PKG: Update dependencies
Note over PKG: @backstage/core-components<br/>workspace:^ → 0.1.0<br/>@backstage/core-plugin-api<br/>workspace:^ → 0.1.0
rect rgb(240, 240, 240)
Note over NPM,REG: Before Change (workspace:^)
Dev->>NPM: npm install
NPM->>WS: Resolve workspace dependencies
WS-->>NPM: Return local packages
NPM-->>Dev: Install from workspace
end
rect rgb(220, 240, 220)
Note over NPM,REG: After Change (0.1.0)
Dev->>NPM: npm install
NPM->>REG: Fetch @backstage/core-components@0.1.0
REG-->>NPM: Return published package
NPM->>REG: Fetch @backstage/core-plugin-api@0.1.0
REG-->>NPM: Return published package
NPM-->>Dev: Install from registry
end
Note over Dev,REG: Plugin now uses fixed versions<br/>instead of workspace references
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/home-react/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR transitions the home-react plugin from workspace-based dependencies to explicit version pinning for core Backstage packages.
@backstage/core-componentsdependency fromworkspace:^to0.1.0@backstage/core-plugin-apidependency fromworkspace:^to0.1.0