Skip to content

[Snyk] Fix for 6 vulnerabilities #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/search-backend-module-pg/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-backend-node": "0.1.2",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +39 to +43
Copy link

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes replace workspace:^ with pinned versions for several @backstage packages. This is a significant and likely incorrect change for a Backstage monorepo. The workspace: protocol is used by Yarn to link to local packages within this monorepo. Pinning to external registry versions will break this linkage, potentially causing build failures, incorrect behavior during local development, and issues with dependency resolution.

The correct approach to update these dependencies and resolve their transitive vulnerabilities is to update the source packages within the monorepo itself and then run yarn install to update the yarn.lock file.

I recommend reverting these specific changes and addressing the vulnerabilities by updating the appropriate packages within the workspace. The lodash update on line 45 is likely correct, but these changes for @backstage packages are problematic.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/plugin-search-backend-node": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

"knex": "^2.0.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"uuid": "^8.3.2",
"winston": "^3.2.1"
},
Expand Down
Loading