-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by updating several key Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix several vulnerabilities by updating dependencies in plugins/kafka/package.json. However, the proposed changes are incorrect and will likely break the project. The PR replaces monorepo workspace-local dependencies (workspace:^) with very old, hardcoded versions from a public registry. This constitutes a major version downgrade and breaks the internal dependency structure of the monorepo. I have left a critical comment explaining why these changes should be reverted and how the vulnerabilities should be addressed properly. This PR should not be merged in its current state.
| "@backstage/core-components": "0.1.0", | ||
| "@backstage/core-plugin-api": "0.1.0", | ||
| "@backstage/plugin-catalog-react": "0.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependency changes are incorrect and will likely break the application. The workspace:^ protocol is used to link to other packages within this monorepo. By replacing it with very old, hardcoded versions, you are breaking this link and introducing a massive version downgrade.
For example:
@backstage/core-componentsis being downgraded from a workspace version (the current version in the repo is0.13.4-next.0) to0.1.0.@backstage/core-plugin-apiis being downgraded from a workspace version (current is1.5.3) to0.1.0.@backstage/plugin-catalog-reactis being downgraded from a workspace version (recent versions are~1.8.0) to0.0.1.
This will cause major compatibility issues and almost certainly fail to build. The correct approach to fix the underlying vulnerabilities is to update the transitive dependencies that are vulnerable, not to downgrade these core packages. This PR should be rejected, and the vulnerabilities should be addressed by updating the correct packages in the monorepo. Please revert these changes.
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^"
WalkthroughThis PR updates the dependency management strategy for the Kafka plugin by replacing workspace protocol references with fixed version numbers. The changes affect three Backstage dependencies: Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant Package as package.json
participant Registry as NPM Registry
Note over Dev,Registry: Dependency Version Update Process
Dev->>Package: Update dependency versions
Note over Package: @backstage/core-components: workspace:^ → 0.1.0<br/>@backstage/core-plugin-api: workspace:^ → 0.1.0<br/>@backstage/plugin-catalog-react: workspace:^ → 0.0.1
Dev->>Registry: Install dependencies
Registry-->>Dev: Fetch specific versions (0.1.0, 0.1.0, 0.0.1)
Note over Dev: Dependencies now pinned to<br/>specific versions instead of<br/>workspace references
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/kafka/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
Updated Kafka plugin dependency version constraints from workspace protocol to fixed versions.
@backstage/core-componentsfromworkspace:^to0.1.0@backstage/core-plugin-apifromworkspace:^to0.1.0@backstage/plugin-catalog-reactfromworkspace:^to0.0.1