Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 24, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • etl/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2026

⚠️ No Changeset found

Latest commit: df05ea4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by performing a major version upgrade of the webpack dependency. The primary goal is to remediate a known security vulnerability, ensuring the project utilizes a more secure and up-to-date build tool.

Highlights

  • Webpack Upgrade: The webpack dependency has been upgraded from version 4.46.0 to 5.0.0 in etl/package.json.
  • Security Fix: This upgrade addresses a medium-severity vulnerability (SNYK-JS-ELLIPTIC-14908844) related to 'Use of a Cryptographic Primitive with a Risky Implementation'.
  • Yarn Lock Manual Update Required: The yarn.lock file was not automatically updated and requires manual intervention before merging, especially for projects utilizing Yarn's zero-installs feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This Snyk PR upgrades webpack to v5 to fix a security vulnerability. However, this is a major version bump with breaking changes, and the PR in its current state is incomplete, which will likely break your build. To successfully upgrade to webpack v5, you also need to upgrade several related dependencies: @rails/webpacker to v6, webpack-cli to v4, and webpack-dev-server to v4. I've added a detailed comment with a code suggestion on package.json to address this. After updating the dependencies, please remember to run yarn install to update yarn.lock and review your webpack configurations for any necessary adjustments for v5.

Comment on lines 8 to 11
"@rails/webpacker": "5.4.3",
"turbolinks": "^5.2.0",
"webpack": "^4.46.0",
"webpack": "^5.0.0",
"webpack-cli": "^3.3.12"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading webpack to version 5 is a major change that introduces breaking changes and requires several other dependencies to be updated for compatibility. The current configuration will likely lead to build failures.

Here are the required changes:

  • @rails/webpacker: Must be upgraded to v6 to support webpack 5. The current version 5.4.3 is not compatible. Note that the latest v6 is a release candidate (6.0.0-rc.6).
  • webpack-cli: Webpack 5 requires webpack-cli v4. The current version ^3.3.12 is incompatible.
  • webpack-dev-server: This is in your devDependencies and also needs to be upgraded to v4 (e.g., ^4.7.3) for webpack 5 compatibility. The current version is ^3.

After updating these dependencies, you will also need to run yarn install to update yarn.lock and you may need to adjust your webpack configuration files (etl/config/webpack/*.js) as per the webpack 5 migration guide.

Suggested change
"@rails/webpacker": "5.4.3",
"turbolinks": "^5.2.0",
"webpack": "^4.46.0",
"webpack": "^5.0.0",
"webpack-cli": "^3.3.12"
"@rails/webpacker": "^6.0.0-rc.6",
"turbolinks": "^5.2.0",
"webpack": "^5.0.0",
"webpack-cli": "^4.9.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants