-
Notifications
You must be signed in to change notification settings - Fork 2
[Snyk] Security upgrade webpack from 4.46.0 to 5.0.0 #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844
|
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by performing a major version upgrade of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This Snyk PR upgrades webpack to v5 to fix a security vulnerability. However, this is a major version bump with breaking changes, and the PR in its current state is incomplete, which will likely break your build. To successfully upgrade to webpack v5, you also need to upgrade several related dependencies: @rails/webpacker to v6, webpack-cli to v4, and webpack-dev-server to v4. I've added a detailed comment with a code suggestion on package.json to address this. After updating the dependencies, please remember to run yarn install to update yarn.lock and review your webpack configurations for any necessary adjustments for v5.
| "@rails/webpacker": "5.4.3", | ||
| "turbolinks": "^5.2.0", | ||
| "webpack": "^4.46.0", | ||
| "webpack": "^5.0.0", | ||
| "webpack-cli": "^3.3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading webpack to version 5 is a major change that introduces breaking changes and requires several other dependencies to be updated for compatibility. The current configuration will likely lead to build failures.
Here are the required changes:
@rails/webpacker: Must be upgraded to v6 to support webpack 5. The current version5.4.3is not compatible. Note that the latest v6 is a release candidate (6.0.0-rc.6).webpack-cli: Webpack 5 requireswebpack-cliv4. The current version^3.3.12is incompatible.webpack-dev-server: This is in yourdevDependenciesand also needs to be upgraded to v4 (e.g.,^4.7.3) for webpack 5 compatibility. The current version is^3.
After updating these dependencies, you will also need to run yarn install to update yarn.lock and you may need to adjust your webpack configuration files (etl/config/webpack/*.js) as per the webpack 5 migration guide.
| "@rails/webpacker": "5.4.3", | |
| "turbolinks": "^5.2.0", | |
| "webpack": "^4.46.0", | |
| "webpack": "^5.0.0", | |
| "webpack-cli": "^3.3.12" | |
| "@rails/webpacker": "^6.0.0-rc.6", | |
| "turbolinks": "^5.2.0", | |
| "webpack": "^5.0.0", | |
| "webpack-cli": "^4.9.1" |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
etl/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-ELLIPTIC-14908844
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.