Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions jsql/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
import logging
import six
import itertools, collections
import sqlalchemy
from packaging import version

_SA_VERSION = version.parse(sqlalchemy.__version__)

class UnsafeSqlException(Exception):
pass
Expand Down Expand Up @@ -81,7 +85,12 @@ def dangerously_inject_sql(value):

def execute_sql(engine, query, params):
from sqlalchemy.sql import text
from sqlalchemy.engine import Engine
q = text(query)
if _SA_VERSION.major >= 2:
if isinstance(engine, Engine):
raise TypeError("SQLAlchemy 2.0 removed Engine.execute(). Pass a Connection instead.")
return engine.execute(q, params)
is_session = 'session' in repr(engine.__class__).lower()
return engine.execute(q, params=params) if is_session else engine.execute(q, **params)

Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
author_email='hzarka@gmail.com',
packages = find_packages(),
package_dir = {'': '.'},
requires = ["six"],
install_requires = ["six"],
requires = ["six", "packaging"],
install_requires = ["six", "packaging"],
classifiers=[
'Development Status :: 3 - Alpha',
'Environment :: Web Environment',
Expand Down