-
Notifications
You must be signed in to change notification settings - Fork 82
Reverse proxy in DDEV cluster #2999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview of modified filesPreview of modified Markdown: |
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
|
@adriendupuis : I tested by runing the following script on an existing project: After this, responses still were showing Could you check/confirm ? and: ^ works for me |
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
mnocon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for preparing this!
My main suggestion is to add more links to HTTP cache docs, to connect these two areas of the doc together.
Maybe add a section in HTTP cache docs as well, something along the lines of "See "Varnish with ddev" to learn how to set it up locally with DDEV" (not the exact wording)
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
| content-length: 45678 | ||
| ``` | ||
|
|
||
| You can see how the `web` server is responding to `varnish`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs a link to HTTP cache doc, that's pretty advanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I linked to other examples below (added in e3bfc13)
| ddev varnishlog -q "'ReqMethod ~ PURGE.*'"; | ||
| ``` | ||
|
|
||
| For more information on topics such as available configurations, command lines, or monitoring, see [ddev/ddev-varnish README](https://github.com/ddev/ddev-varnish). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link again to http cache for more info how to use that with Ibexa? That's up to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see what to link to in the actual state of our doc.
Kept for later.
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
mnocon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just two small suggestions which I think sound better
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/clustering/clustering_with_ddev.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
* clustering_with_ddev.md: Install reverse proxy * clustering_with_ddev.md: web's proxy config * clustering_with_ddev.md: invalidators; ddev varnishlog * clustering_with_ddev.md: TRUSTED_PROXIES * clustering_with_ddev.md: Fastly --------- Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
How to add a reverse proxy Varnish or Fastly, into a DDEV cluster.
Preview https://ez-systems-developer-documentation--2999.com.readthedocs.build/en/2999/infrastructure_and_maintenance/clustering/clustering_with_ddev/#install-reverse-proxy
Checklist