CROSSLINK-204 itemLocation, requesterPickupLocation

[adamdickmeiss]

https://index-data.atlassian.net/browse/CROSSLINK-204

[Copilot]

Pull request overview

Adds configurable LMS location settings to support CROSSLINK-204, enabling separate pickup locations for requester vs supplier flows and allowing an optional item location to be sent with NCIP RequestItem.

Changes:

• Extend Directory LMS config schema with itemLocation and requesterPickupLocation.
• Update the LmsAdapter interface and broker action flow to use RequesterPickupLocation, SupplierPickupLocation, and ItemLocation.
• Enhance NCIP RequestItem to optionally include ItemOptionalFields.Location when an item location is provided, and update tests/mocks accordingly.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
illmock/dirmock/directories.json	Updates mock directory data to the current lookupUserEnabled config shape.
directory/directory_api.yaml	Adds new LMS config fields for item location and requester pickup location.
broker/patron_request/service/action_test.go	Updates test adapter mock to satisfy the expanded LmsAdapter interface; removes obsolete pickup-location parsing test.
broker/patron_request/service/action.go	Switches borrowing/lending flows to use adapter-provided pickup/item locations.
broker/lms/lms_adapter_test.go	Updates/extends tests for new pickup/item-location behaviors in the NCIP adapter.
broker/lms/lms_adapter_ncip.go	Implements new config-backed getters and includes optional item location in NCIP RequestItem payload.
broker/lms/lms_adapter_manual.go	Updates manual adapter to satisfy new interface methods.
broker/lms/lms_adapter.go	Expands the LMS adapter interface with requester/supplier pickup location and item location getters.