Update cargo doc commands to remove examples flag, remove -D warnings #100
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed '--examples' flag from cargo doc commands.
Removed the '-D warnings' flag from Clippy checks in the workflow.
rswanson
changed the title
Fraser999
reviewed
Jan 27, 2026
.github/workflows/rust-base.yml
Outdated
| env: | ||
| CARGO_NET_GIT_FETCH_WITH_CLI: true | ||
| run: cargo clippy --all-targets --all-features --workspace --locked --profile ${{ inputs.rust-profile }} -- -D warnings | ||
| run: cargo clippy --all-targets --all-features --workspace --locked --profile ${{ inputs.rust-profile }} |
There was a problem hiding this comment.
I'd think we want to keep -- -D warnings here and below so that CI fails if clippy emits warnings.
Keep clippy consistent with docs job which uses RUSTDOCFLAGS: -D warnings. Also fixes a stray double space. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
Restored |
prestwich
approved these changes
Feb 2, 2026
Fraser999
approved these changes
Feb 2, 2026
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed '--examples' flag from cargo doc commands.