chore: make ImmutableMetadata optional
#178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This pull request refactors the handling of immutable metadata in the audit trail Move module, making the metadata optional and simplifying its structure. It is not ergonomic to have both fields as optional and can be simplified to follow better code conventions.
Audit trail metadata model changes:
TrailImmutableMetadatastruct so thatnameis now a requiredStringinstead of anOption<String>, whiledescriptionremains optional. (audit-trail-move/sources/audit_trail.move)immutable_metadatafield ofAuditTrailanOption<TrailImmutableMetadata>instead of a required value, allowing audit trails to be created without immutable metadata. (audit-trail-move/sources/audit_trail.move) [1] [2]new_trail_metadataconstructor to require aStringfornameand anOption<String>fordescription. (audit-trail-move/sources/audit_trail.move)API and getter updates:
trail_nameandtrail_description) to handle the optional nature ofimmutable_metadata, returningOption<String>as appropriate. (audit-trail-move/sources/audit_trail.move)Links to any relevant issues
Type of change
How the change has been tested
Change checklist