Handle encrypted key pair exception #338
Open
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I've no idea why the one maven check is failing, help wanted. |
kares
reviewed
Jan 15, 2026
Member
kares
left a comment
kares
left a comment
There was a problem hiding this comment.
Thanks for the effort Danie, unfortunately this doesn't seem right.
Maybe we would be better of starting with a minimal reproducer (test-case).
| } catch (IllegalArgumentException e) { | ||
| if (pemObject instanceof PEMEncryptedKeyPair) { | ||
| try { | ||
| PEMEncryptedKeyPair encrypted = (PEMEncryptedKeyPair) pemObject; |
Member
There was a problem hiding this comment.
if we're dealing with the pemObject instanceof PEMEncryptedKeyPair then that could be checked earlier, instead of catching the IllegalArgumentException...
also bellow we just provide a null password and hope it works, why?
Author
|
@kares Probably the easiest way to see what I'm seeing is to clone https://github.com/djberg96/sys-filesystem and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address jruby/jruby#8254 where an exception occurs if I try to generate a rubygem with a signed cert.
Note that this is AI generated code (I don't really know Java), so I'm happy to make changes if you think it needs them.