Fix kagent-tools fullnameOverride

[ricky9408]

FIx this issue #1190

[EItanya]

IIRC this used to be necessary, but I can't for the life of me remember why, I will respond again if I can think of it 😆

[ricky9408]

@EItanya
Thanks for the response!

During the CI testing, 1 CI has failed.

Error: 2 errors occurred:
	* clusterrolebindings.rbac.authorization.k8s.io "kagent-getter-rolebinding" already exists
	* clusterrolebindings.rbac.authorization.k8s.io "kagent-writer-rolebinding" already exists


make: *** [Makefile:327: helm-install-provider] Error 1
Error: Process completed with exit code 2.

I investigated the CI logs and I found that both kagent chart and kagent-tools chart are creating same clusterrolebindings.

Reference: https://github.com/kagent-dev/tools/blob/main/helm/kagent-tools/templates/clusterrolebinding.yaml

So that I added this commit for this conflict.

May I ask for this to be checked as well? Thanks.

[ricky9408]

@EItanya

The CI failed again.
However, previous problem was resolved.

Seems there are dockerhub rate limit exceeded issue.

May I ask for the retry of the failed job? Thanks.

Log:

bash ./scripts/kind/setup-kind.sh
Unable to find image 'registry:2' locally
docker: Error response from daemon: Head "https://registry-1.docker.io/v2/library/registry/manifests/2": Get "https://auth.docker.io/token?account=githubactions&scope=repository%3Alibrary%2Fregistry%3Apull&service=registry.docker.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Run 'docker run --help' for more information
make: *** [Makefile:180: create-kind-cluster] Error 125

[EItanya]

May I ask for the retry of the failed job? Thanks.

Re-running now

[EItanya]

@onematchfox I'd love to get your eyes on this. It seems simple but it's the type of change with potential hiding dragons and you're an expert at seeing those

[onematchfox]

Suggested change

	fullnameOverride: kagent-tools
	nameOverride: tools

Removing fullnameOverride will resulting in any resources created by the kagent-tools chart being created using just the release name supplied when installing this chart. See https://github.com/kagent-dev/tools/blob/9cc60665518f6c0d0bf11f10fbc07f220efa019f/helm/kagent-tools/templates/_helpers.tpl#L8-L21

I.e. in the default scenario this will result in thge deployment kagent-tools being deleted and a new deployment called kagent being created. To preserve the existing name whilst also honouring the release name supplied when installing this chart we should make use of nameOverride instead. This is how this is done for the kmcp chart as well.

FYI: This is also why you ended up having to change the name of the cluster role bindings. So, you should be able to revert that change after making this one.