Skip to content

Replace crane with krane to support cloud registry auth for skills #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
s10gopal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace crane with krane to support cloud registry auth for skills #1236

s10gopal wants to merge 1 commit into from
+30 −9

Conversation

@s10gopal
Copy link

@s10gopal s10gopal commented Jan 23, 2026

Summary

Replace crane with krane for container registry operations. krane is a drop-in replacement for crane that adds built-in support for cloud workload identity authentication (GKE, EKS), enabling better authentication in cloud environments without requiring additional credential configuration.

Changes

  • python/Dockerfile: Updated package installation from crane to krane
  • python/packages/kagent-adk/src/kagent/adk/skill_fetcher.py:
    • Renamed fetch_using_crane_to_dir() to fetch_using_krane_to_dir()
    • Updated command invocation to use krane instead of crane
    • Updated function documentation and comments

Benefits

  • Automatic authentication with cloud workload identity mechanisms (GKE, EKS)
  • No additional credential configuration required
  • Drop-in replacement maintains existing functionality

Testing

  • Verified Dockerfile builds successfully with krane package
  • Functionality remains unchanged (drop-in replacement)

References

Co-author

Co-authored-by: @sharmagaurav602

@s10gopal s10gopal changed the title Replace crane with krane Replace crane with krane #1222 Jan 23, 2026
@s10gopal s10gopal changed the title Replace crane with krane #1222 Replace crane with krane Jan 23, 2026
@s10gopal s10gopal mentioned this pull request Jan 23, 2026
Open
3 tasks
@s10gopal s10gopal force-pushed the skill-auth branch 3 times, most recently from 1e24f7b to 217d235 Compare January 23, 2026 06:06
@s10gopal s10gopal changed the title Replace crane with krane Replace crane with krane to support cloud registry auth for skills Jan 23, 2026
yuval-k
yuval-k previously approved these changes Jan 23, 2026
View reviewed changes
@s10gopal @sharmagaurav602
Replace crane with krane
88da699 
krane is a drop-in replacement for crane with built-in support for
cloud workload identity authentication (GKE, EKS).

Co-authored-by: sharmagaurav602 <sharmagaurav602@users.noreply.github.com>
Signed-off-by: Gopal Sharma <s10gopal@gmail.com>
@s10gopal s10gopal requested a review from yuval-k January 24, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EItanya EItanya Awaiting requested review from EItanya EItanya is a code owner

@peterj peterj Awaiting requested review from peterj peterj is a code owner

@yuval-k yuval-k Awaiting requested review from yuval-k yuval-k is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s10gopal @yuval-k