-
Notifications
You must be signed in to change notification settings - Fork 0
support ET_DYN output in self linker #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| int foo() { return 42; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| require_relative "../../test_suite" | ||
|
|
||
| class Caotral::Linker::SharedObjectLinkingTest < Test::Unit::TestCase | ||
| include TestProcessHelper | ||
| def setup | ||
| @inputs = ["shared.o"] | ||
| @output = "libshared.so" | ||
| path = Pathname.new("sample/C/shared-object.c").to_s | ||
| IO.popen(["gcc", "-fPIC", "-c", "-o", @inputs[0], "%s" % path]).close | ||
| end | ||
|
|
||
| def teardown | ||
| File.delete(@inputs[0]) if File.exist?(@inputs[0]) | ||
| File.delete(@output) if File.exist?(@output) | ||
| end | ||
|
|
||
| def test_link_shared_object | ||
| Caotral::Linker.link!(inputs: @inputs, output: @output, linker: "self", shared: true, executable: false) | ||
| elf = Caotral::Binary::ELF::Reader.read!(input: @output, debug: false) | ||
| assert_equal(:DYN, elf.header.type) | ||
| assert_equal(:AMD64, elf.header.arch) | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initializer now directly indexes
ELF_FILE_TYPE[type]and dropped the previous normalization logic, so callers that still passtype: :rel/:execor string values (which were accepted before) will now hitniland raise aTypeErrorinsidenum2bytes. Also, removing thearc:keyword means any existing caller supplyingarc:now gets anArgumentError. This is a runtime regression for existing usage patterns; consider keeping the normalization/keyword or raising a clearer validation error.Useful? React with 👍 / 👎.